master: Drop support for EOL Python 2.6 and 3.0-3.3#617
Closed
hugovk wants to merge 7 commits intosendgrid:masterfrom
Closed
master: Drop support for EOL Python 2.6 and 3.0-3.3#617hugovk wants to merge 7 commits intosendgrid:masterfrom
hugovk wants to merge 7 commits intosendgrid:masterfrom
Conversation
thinkingserious
added
the
status: code review request
Codecov Report
@@ Coverage Diff @@
## master #617 +/- ##
=======================================
Coverage 84.77% 84.77%
=======================================
Files 35 35
Lines 1156 1156
Branches 172 172
=======================================
Hits 980 980
Misses 90 90
Partials 86 86
Continue to review full report at Codecov.
|
Contributor
|
Hello @hugovk, Could you please move these changes to this branch? Thanks! With Best Regards, Elmer |
thinkingserious
added
type: community enhancement
5 tasks
Contributor
Author
|
Please see PR #626. |
hugovk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Short description of what this PR does:
Python 2.6 and 3.0-3.3 are EOL and no longer receiving security updates (or any updates) from the core Python team.
They're also little used.
Here's the pip installs for sendgrid from PyPI for September 2018:
Source:
pypinfo --start-date 2018-09-01 --end-date 2018-09-30 --percent --markdown sendgrid pyversionI see #352 (comment) notes support for 2.6 is planned to be dropped in the next SDK version, and I don't think 3.0-3.2 were supported anyway.
This PR also upgrades code to use newer Python syntax, removes some old compatibility code, and fixes some flake8 and inspection warnings.